rdblue commented on code in PR #7064:
URL: https://github.com/apache/iceberg/pull/7064#discussion_r1132711344
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##########
@@ -116,6 +122,11 @@ public void initialize(String name, Map<String, String>
properties) {
}
}
+ public void setFileIOBuilder(Function<Map<String, String>, FileIO>
ioBuilder) {
Review Comment:
I looked into adding this to `BaseMetastoreCatalog` but it didn't make
sense. That class is not `Configurable` and creating an IO requires a
`Configuration` when the subclasses implement it. As a result, this class would
need to override both this method and a `newFileIO` method so it isn't worth it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
