rdblue commented on code in PR #7064:
URL: https://github.com/apache/iceberg/pull/7064#discussion_r1132722008
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -762,16 +765,25 @@ private String fullTableName(TableIdentifier ident) {
return String.format("%s.%s", name(), ident);
}
+ private FileIO newFileIO(Map<String, String> properties) {
+ if (null != ioBuilder) {
+ return ioBuilder.apply(properties);
+ } else {
+ String ioImpl = properties.get(CatalogProperties.FILE_IO_IMPL);
+ return
+ CatalogUtil.loadFileIO(
+ ioImpl != null ? ioImpl : ResolvingFileIO.class.getName(),
properties, conf);
Review Comment:
I updated this to be more like the JDBC catalog, where we use `getOrDefault`
on the line above to clean it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
