jackye1995 commented on code in PR #6965:
URL: https://github.com/apache/iceberg/pull/6965#discussion_r1131439559
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/BaseBatchReader.java:
##########
@@ -42,11 +42,12 @@
BaseBatchReader(
Table table,
+ String branch,
Review Comment:
It feels a bit awkward to implement a `TableWithBranch extends Table` and
vend schema through `table.schema()` just to avoid changing constructors,
because it is not a table and does not have all the other capabilities.
I decided to pass in a `String branch` instead of `Schema snapshotSchema`
just because it seems simpler, but the other way would also work, but will also
pass schema all the way to all readers with mostly the same amount of changes.
This might be fine though, would like to know what others think as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
