aokolnychyi commented on code in PR #6965:
URL: https://github.com/apache/iceberg/pull/6965#discussion_r1130520734
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java:
##########
@@ -83,7 +91,14 @@ public Long endSnapshotId() {
}
public String branch() {
- return
confParser.stringConf().option(SparkReadOptions.BRANCH).parseOptional();
+ String optionBranch =
confParser.stringConf().option(SparkReadOptions.BRANCH).parseOptional();
Review Comment:
What's the use for the option if we support AS OF tag/branch? My worry is
that we add something that is going to work only in some cases. Doesn't Spark
have some special DataFrame options to do time travel that we can use for
branches?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
