aokolnychyi commented on code in PR #6965:
URL: https://github.com/apache/iceberg/pull/6965#discussion_r1130539225
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/PositionDeletesRowReader.java:
##########
@@ -47,18 +47,20 @@ class PositionDeletesRowReader extends
BaseRowReader<PositionDeletesScanTask>
PositionDeletesRowReader(SparkInputPartition partition) {
this(
partition.table(),
+ partition.branch(),
partition.taskGroup(),
partition.expectedSchema(),
partition.isCaseSensitive());
}
PositionDeletesRowReader(
Table table,
+ String branch,
ScanTaskGroup<PositionDeletesScanTask> taskGroup,
Schema expectedSchema,
boolean caseSensitive) {
- super(table, taskGroup, expectedSchema, caseSensitive);
+ super(table, branch, taskGroup, expectedSchema, caseSensitive);
Review Comment:
All these changes make we wonder if we could hide the branching logic behind
a special `Table` impl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
