rdblue commented on code in PR #6951:
URL: https://github.com/apache/iceberg/pull/6951#discussion_r1125183736
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -628,6 +630,43 @@ public class AwsProperties implements Serializable {
*/
public static final String LAKE_FORMATION_DB_NAME = "lakeformation.db-name";
+ /** Region to be used by the SigV4 protocol for signing requests. */
+ public static final String REST_SIGV4_SIGNER_REGION =
"rest.sigv4.signing-region";
+
+ /** The service name to be used by the SigV4 protocol for signing requests.
*/
+ public static final String REST_SIGV4_SIGNING_NAME =
"rest.sigv4.signing-name";
+
+ /** The default service name (API Gateway and lambda) used during SigV4
signing. */
+ public static final String REST_SIGV4_SIGNING_NAME_DEFAULT = "execute-api";
+
+ /**
+ * Configure the static access key ID used for SigV4 signing.
+ *
+ * <p>When set, the default client factory will use the basic or session
credentials provided
+ * instead of reading the default credential chain to create S3 access
credentials. If {@link
+ * #REST_SIGV4_SESSION_TOKEN} is set, session credential is used, otherwise
basic credential is
+ * used.
+ */
+ public static final String REST_SIGV4_ACCESS_KEY_ID =
"rest.sigv4.access-key-id";
Review Comment:
Do we need both `rest` and `sigv4` prefixes?
If we removed "rest" then this would appear more generic because it isn't
clear what SigV4 connections this applies to. We should probably keep `rest`
then.
If we remove "sigv4" then we would have `rest.access-key-id`,
`rest.session-token`, `rest.sigv4-enabled`, etc. Those seem fairly reasonable
to me... but I'm definitely not sure they belong in `AwsProperties`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
