rdblue commented on code in PR #6951:
URL: https://github.com/apache/iceberg/pull/6951#discussion_r1125181619
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -361,6 +383,55 @@ public void close() throws IOException {
httpClient.close(CloseMode.GRACEFUL);
}
+ public static HTTPClient buildFrom(Map<String, String> properties) {
Review Comment:
I know this is intended to clean up, but it now creates two different ways
to build a client. I'd prefer to have just one, but I don't really care whether
that is to deprecate the builder and only use this method or whether it is to
keep the builder and add properties to it.
I have a slight preference for adding properties to the builder since the
`S3V4RestSignerClient` uses the `uri` method. Basically, that would mean adding
a new `builder(Map<String, String>)` factory method. Then that method would do
everything that this method does, but return the builder at the end for
overrides.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
