rdblue commented on code in PR #6951:
URL: https://github.com/apache/iceberg/pull/6951#discussion_r1125174971
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -393,10 +465,15 @@ public Builder withObjectMapper(ObjectMapper
objectMapper) {
return this;
}
+ public Builder withRequestInterceptor(HttpRequestInterceptor interceptor) {
Review Comment:
Unless we need to make this public, I would rather not because it leaks the
HttpRequestInterceptor through the Iceberg API. I think it can be private.
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -393,10 +465,15 @@ public Builder withObjectMapper(ObjectMapper
objectMapper) {
return this;
}
+ public Builder withRequestInterceptor(HttpRequestInterceptor interceptor) {
Review Comment:
Unless we need to make this public, I would rather not because it leaks the
HttpRequestInterceptor through the Iceberg API. I think it can be private, at
least for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
