ajantha-bhat commented on code in PR #6661:
URL: https://github.com/apache/iceberg/pull/6661#discussion_r1123011566
##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -220,21 +251,53 @@ Iterable<Partition> all() {
static class Partition {
private final StructLike key;
- private long recordCount;
- private int fileCount;
private int specId;
+ private long dataRecordCount;
+ private int dataFileCount;
+
+ private final Set<DeleteFile> equalityDeleteFiles;
+ private final Set<DeleteFile> positionDeleteFiles;
Review Comment:
https://github.com/apache/iceberg/blob/76c1df0cfde27167d31c112c81daa2d4fcc96686/api/src/main/java/org/apache/iceberg/RewriteFiles.java#L71
`Set<DeleteFile>` was already used in the existing code, as seen above.
But there are no equals() and hashcode() impl for these classes. Which means
it is using the default ones.
Note that `Set<DataFile>` also exist in the code and it also doesn't have
equal/hashcode impl.
I am ok with using Paths. But just wondering why it doesn't exist and maybe
we can handle these in a follow-up PR instead of this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
