szehon-ho commented on code in PR #6661: URL: https://github.com/apache/iceberg/pull/6661#discussion_r1122537693
########## core/src/main/java/org/apache/iceberg/PartitionsTable.java: ########## @@ -220,21 +251,53 @@ Iterable<Partition> all() { static class Partition { private final StructLike key; - private long recordCount; - private int fileCount; private int specId; + private long dataRecordCount; + private int dataFileCount; + + private final Set<DeleteFile> equalityDeleteFiles; + private final Set<DeleteFile> positionDeleteFiles; Review Comment: Can you double check DeleteFile equal/hashcode are working correctly, if conflict? Should we rather do something safer, like paths? Maybe it will even be better for memory? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org