ajantha-bhat commented on code in PR #6661:
URL: https://github.com/apache/iceberg/pull/6661#discussion_r1095640760


##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -236,5 +273,17 @@ void update(DataFile file) {
       this.fileCount += 1;
       this.specId = file.specId();
     }
+
+    void update(DeleteFile file) {
+      if (file.content() == FileContent.POSITION_DELETES) {
+        this.posDeleteRecordCount += file.recordCount();

Review Comment:
   oh. I didn't know there was a PR that worked on this. 
   Thanks for pointing to it. I will take a look at it. 
   
   What about de-dup for equality deletes? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to