aokolnychyi commented on code in PR #6682:
URL: https://github.com/apache/iceberg/pull/6682#discussion_r1122682061
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/procedures/ExpireSnapshotsProcedure.java:
##########
@@ -114,7 +119,17 @@ public InternalRow[] call(InternalRow args) {
}
if (maxConcurrentDeletes != null) {
- action.executeDeleteWith(executorService(maxConcurrentDeletes,
"expire-snapshots"));
+ if (table.io() instanceof SupportsBulkOperations) {
+ LOG.warn(
+ "max_concurrent_deletes only works with FileIOs that do not
support bulk deletes. This"
+ + "table is currently using {} which supports bulk
deletes so the parameter will be ignored. "
+ + "See that IO's documentation to learn how to adjust
parallelism for that particular "
+ + "IO's bulk delete.",
+ table.io());
Review Comment:
Also `table.io().getClass().getName()`?
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/procedures/RemoveOrphanFilesProcedure.java:
##########
@@ -154,7 +158,17 @@ public InternalRow[] call(InternalRow args) {
}
if (maxConcurrentDeletes != null) {
- action.executeDeleteWith(executorService(maxConcurrentDeletes,
"remove-orphans"));
+ if (table.io() instanceof SupportsBulkOperations) {
+ LOG.warn(
+ "max_concurrent_deletes only works with FileIOs that do not
support bulk deletes. This"
+ + "table is currently using {} which supports bulk
deletes so the parameter will be ignored. "
+ + "See that IO's documentation to learn how to adjust
parallelism for that particular "
+ + "IO's bulk delete.",
+ table.io());
Review Comment:
Same here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
