aokolnychyi commented on code in PR #6682:
URL: https://github.com/apache/iceberg/pull/6682#discussion_r1122679902
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/DeleteReachableFilesSparkAction.java:
##########
@@ -132,7 +126,20 @@ private Dataset<FileInfo> reachableFileDS(TableMetadata
metadata) {
}
private DeleteReachableFiles.Result deleteFiles(Iterator<FileInfo> files) {
- DeleteSummary summary = deleteFiles(deleteExecutorService, deleteFunc,
files);
+ DeleteSummary summary;
+ if (deleteFunc == null && io instanceof SupportsBulkOperations) {
+ summary = deleteFiles((SupportsBulkOperations) io, files);
+ } else {
+
Review Comment:
I actually meant an empty line after `DeleteSummary` var but formatting here
is up to you.
I like the new pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
