RussellSpitzer commented on code in PR #6682: URL: https://github.com/apache/iceberg/pull/6682#discussion_r1120393853
########## core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java: ########## @@ -18,27 +18,42 @@ */ package org.apache.iceberg.hadoop; +import java.io.FileNotFoundException; import java.io.IOException; import java.io.UncheckedIOException; import java.util.Iterator; import java.util.Map; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.atomic.AtomicInteger; import java.util.function.Function; import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.fs.FileSystem; import org.apache.hadoop.fs.Path; import org.apache.hadoop.fs.RemoteIterator; import org.apache.iceberg.exceptions.RuntimeIOException; +import org.apache.iceberg.io.BulkDeletionFailureException; import org.apache.iceberg.io.FileIO; import org.apache.iceberg.io.FileInfo; import org.apache.iceberg.io.InputFile; import org.apache.iceberg.io.OutputFile; +import org.apache.iceberg.io.SupportsBulkOperations; import org.apache.iceberg.io.SupportsPrefixOperations; import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap; import org.apache.iceberg.relocated.com.google.common.collect.Streams; import org.apache.iceberg.util.SerializableMap; import org.apache.iceberg.util.SerializableSupplier; +import org.apache.iceberg.util.Tasks; +import org.apache.iceberg.util.ThreadPools; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; -public class HadoopFileIO implements FileIO, HadoopConfigurable, SupportsPrefixOperations { +public class HadoopFileIO + implements FileIO, HadoopConfigurable, SupportsPrefixOperations, SupportsBulkOperations { + + private static final Logger LOG = LoggerFactory.getLogger(HadoopFileIO.class); + private static final String DELETE_FILE_PARALLELISM = "iceberg.hadoop.delete_file_parallelism"; Review Comment: I don't think we have any others ... I looked for anything with "hadoop" in it and didn't find any, I can switch to - -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org