RussellSpitzer commented on code in PR #6682:
URL: https://github.com/apache/iceberg/pull/6682#discussion_r1122023544
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/BaseSparkAction.java:
##########
@@ -253,6 +261,38 @@ protected DeleteSummary deleteFiles(
return summary;
}
+ protected DeleteSummary deleteFiles(SupportsBulkOperations io,
Iterator<FileInfo> files) {
+ DeleteSummary summary = new DeleteSummary();
+ Iterator<List<FileInfo>> fileGroups = Iterators.partition(files,
DELETE_GROUP_SIZE);
+
+ Tasks.foreach(fileGroups)
+ .suppressFailureWhenFinished()
+ .run(fileGroup -> deleteFileGroup(fileGroup, io, summary));
+
+ LOG.info("Deleted {} total files with bulk deletes",
summary.totalFilesCount());
+
+ return summary;
+ }
+
+ private static void deleteFileGroup(
+ List<FileInfo> fileGroup, SupportsBulkOperations io, DeleteSummary
summary) {
+ ImmutableListMultimap<String, FileInfo> filesByType =
+ Multimaps.index(fileGroup, FileInfo::getType);
+ ListMultimap<String, String> pathsByType =
+ Multimaps.transformValues(filesByType, FileInfo::getPath);
+ for (Map.Entry<String, Collection<String>> entry :
pathsByType.asMap().entrySet()) {
Review Comment:
my kingdom for a flatmap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
