aokolnychyi commented on code in PR #6682:
URL: https://github.com/apache/iceberg/pull/6682#discussion_r1096394775
##########
api/src/main/java/org/apache/iceberg/actions/DeleteOrphanFiles.java:
##########
@@ -80,9 +84,16 @@ public interface DeleteOrphanFiles extends
Action<DeleteOrphanFiles, DeleteOrpha
*
* @param executorService the service to use
* @return this for method chaining
+ * @deprecated All deletes should be performed using the bulk delete api if
available. Use FileIO
+ * specific parallelism controls to adjust bulk delete concurrency
within that api.
*/
+ @Deprecated
Review Comment:
The original proposal for `SupportsBulkOperations` included a way to pass a
custom executor service, which we removed until we had a use case. Without
having a default executor service in file IO, we would be pushing the
complexity on the user. However, I was talking about having a default executor
service in all file IO implementations but allowing to pass a custom one in
`SupportsBulkOperations`. That way, our defaults are always good but if needed,
one may pass a custom executor service.
```
void deleteFiles(Iterable<String> pathsToDelete) throws
BulkDeletionFailureException;
void deleteFiles(ExecutorService executorService, Iterable<String>
pathsToDelete) throws BulkDeletionFailureException;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
