Fokko commented on code in PR #6714:
URL: https://github.com/apache/iceberg/pull/6714#discussion_r1110434965
##########
python/pyiceberg/table/__init__.py:
##########
@@ -314,11 +314,19 @@ def _check_content(file: DataFile) -> DataFile:
return file
-def _open_manifest(io: FileIO, manifest: ManifestFile, partition_filter:
Callable[[DataFile], bool]) -> List[FileScanTask]:
+def _open_manifest(
+ io: FileIO,
+ schema: Schema,
+ row_filter: BooleanExpression,
+ manifest: ManifestFile,
+ partition_filter: Callable[[DataFile], bool],
+ case_sensitive: bool,
+) -> List[FileScanTask]:
all_files = files(io.new_input(manifest.manifest_path))
matching_partition_files = filter(partition_filter, all_files)
matching_partition_data_files = map(_check_content,
matching_partition_files)
- return [FileScanTask(file) for file in matching_partition_data_files]
+ evaluator = _InclusiveMetricsEvaluator(schema, row_filter, case_sensitive)
Review Comment:
Oeh, I like that _very_ much! Thanks for the sharp observation!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
