Fokko commented on code in PR #6714:
URL: https://github.com/apache/iceberg/pull/6714#discussion_r1118134937
##########
python/tests/expressions/test_visitors.py:
##########
@@ -1024,7 +1024,7 @@ def test_missing_stats(schema: Schema, manifest_no_stats:
ManifestFile) -> None:
), f"Should read when missing stats for expr: {expr}"
-def test_not(schema: Schema, manifest: ManifestFile) -> None:
+def test_not_nan(schema: Schema, manifest: ManifestFile) -> None:
Review Comment:
I replicated two suites to Python:
-
[TestInclusiveMetricsEvaluator.java](https://github.com/apache/iceberg/blob/master/api/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluator.java)
-
[TestMetricsEvaluatorsNaNHandling.java](https://github.com/apache/iceberg/blob/master/api/src/test/java/org/apache/iceberg/expressions/TestMetricsEvaluatorsNaNHandling.java)
The ones coming from `TestMetricsEvaluatorsNaNHandling` have a `_nan`
postfix to avoid duplicate naming. But I think we can just combine them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
