nastra commented on code in PR #6799:
URL: https://github.com/apache/iceberg/pull/6799#discussion_r1109665669
##########
.palantir/revapi.yml:
##########
@@ -261,6 +261,16 @@ acceptedBreaks:
\ T) throws java.io.IOException,
com.fasterxml.jackson.core.JacksonException\
\ @
org.apache.iceberg.rest.RESTSerializers.UpdateRequirementDeserializer"
justification: "False positive - JacksonException is a subclass of
IOException"
+ - code: "java.method.numberOfParametersChanged"
+ old: "method
org.apache.iceberg.io.FileAppender<org.apache.iceberg.ManifestEntry<F>>\
+ \ org.apache.iceberg.ManifestWriter<F extends
org.apache.iceberg.ContentFile<F\
+ \ extends
org.apache.iceberg.ContentFile<F>>>::newAppender(org.apache.iceberg.PartitionSpec,\
+ \ org.apache.iceberg.io.OutputFile)"
+ new: "method
org.apache.iceberg.io.FileAppender<org.apache.iceberg.ManifestEntry<F>>\
+ \ org.apache.iceberg.ManifestWriter<F extends
org.apache.iceberg.ContentFile<F\
+ \ extends
org.apache.iceberg.ContentFile<F>>>::newAppender(org.apache.iceberg.PartitionSpec,\
+ \ org.apache.iceberg.io.OutputFile, java.lang.String,
java.lang.Integer)"
Review Comment:
the example you mentioned is quite old and this was before we were stricter
on API breakages.
As part of #6146 we went back and fixed API breakages by first deprecating
them first. In #6274 we then went ahead and removed those deprecations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
