[GitHub] [iceberg] wypoon commented on a diff in pull request #6799: Core: Use avro compression properties from table properties when writing manifests and manifest lists

[via GitHub]

wypoon commented on code in PR #6799:
URL: https://github.com/apache/iceberg/pull/6799#discussion_r1108930721


##########
.palantir/revapi.yml:
##########
@@ -261,6 +261,16 @@ acceptedBreaks:
         \ T) throws java.io.IOException, 
com.fasterxml.jackson.core.JacksonException\
         \ @ 
org.apache.iceberg.rest.RESTSerializers.UpdateRequirementDeserializer"
       justification: "False positive - JacksonException is a subclass of 
IOException"
+    - code: "java.method.numberOfParametersChanged"
+      old: "method 
org.apache.iceberg.io.FileAppender<org.apache.iceberg.ManifestEntry<F>>\
+        \ org.apache.iceberg.ManifestWriter<F extends 
org.apache.iceberg.ContentFile<F\
+        \ extends 
org.apache.iceberg.ContentFile<F>>>::newAppender(org.apache.iceberg.PartitionSpec,\
+        \ org.apache.iceberg.io.OutputFile)"
+      new: "method 
org.apache.iceberg.io.FileAppender<org.apache.iceberg.ManifestEntry<F>>\
+        \ org.apache.iceberg.ManifestWriter<F extends 
org.apache.iceberg.ContentFile<F\
+        \ extends 
org.apache.iceberg.ContentFile<F>>>::newAppender(org.apache.iceberg.PartitionSpec,\
+        \ org.apache.iceberg.io.OutputFile, java.lang.String, 
java.lang.Integer)"

Review Comment:
   I looked at some of the historical justifications in the revapi.yml. I see, 
e.g., a number of
   ```
         justification: "Allow adding a new method to the interface - old 
method is deprecated"
   ```
   I think that is the way, isn't it? Deprecate the old abstract `newAppender` 
method (with 2 parameters), add a new abstract `newAppender` method (with 4 
parameters), and justify it as
   ```
         justification: "Allow adding a new method to the abstract class - old 
method is deprecated"
   ```
   Otherwise, how would you ever change the API? Am I missing something?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org