[GitHub] [iceberg] wypoon commented on a diff in pull request #6799: Core: Use avro compression properties from table properties when writing manifests and manifest lists

[via GitHub]

wypoon commented on code in PR #6799:
URL: https://github.com/apache/iceberg/pull/6799#discussion_r1108942951


##########
.palantir/revapi.yml:
##########
@@ -261,6 +261,16 @@ acceptedBreaks:
         \ T) throws java.io.IOException, 
com.fasterxml.jackson.core.JacksonException\
         \ @ 
org.apache.iceberg.rest.RESTSerializers.UpdateRequirementDeserializer"
       justification: "False positive - JacksonException is a subclass of 
IOException"
+    - code: "java.method.numberOfParametersChanged"
+      old: "method 
org.apache.iceberg.io.FileAppender<org.apache.iceberg.ManifestEntry<F>>\
+        \ org.apache.iceberg.ManifestWriter<F extends 
org.apache.iceberg.ContentFile<F\
+        \ extends 
org.apache.iceberg.ContentFile<F>>>::newAppender(org.apache.iceberg.PartitionSpec,\
+        \ org.apache.iceberg.io.OutputFile)"
+      new: "method 
org.apache.iceberg.io.FileAppender<org.apache.iceberg.ManifestEntry<F>>\
+        \ org.apache.iceberg.ManifestWriter<F extends 
org.apache.iceberg.ContentFile<F\
+        \ extends 
org.apache.iceberg.ContentFile<F>>>::newAppender(org.apache.iceberg.PartitionSpec,\
+        \ org.apache.iceberg.io.OutputFile, java.lang.String, 
java.lang.Integer)"

Review Comment:
   Here is an example: 
https://github.com/apache/iceberg/commit/128d5a161fda076118a7cab1d95ab5064400e08a.
   Deprecate old method and add new replacement method at the same time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org