nastra commented on code in PR #6837:
URL: https://github.com/apache/iceberg/pull/6837#discussion_r1109447306
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -105,6 +106,14 @@ public String token() {
return properties().get(OAuth2Properties.TOKEN);
}
+ @Value.Lazy
+ boolean refreshAuthByDefault() {
+ return PropertyUtil.propertyAsBoolean(
+ properties(),
+ CatalogProperties.AUTH_DEFAULT_REFRESH_ENABLED,
+ CatalogProperties.AUTH_DEFAULT_REFRESH_ENABLED_DEFAULT);
Review Comment:
I'm ok deprecating and removing `AUTH_DEFAULT_REFRESH_ENABLED`, but I don't
think we increase confusion by using it to control token refresh behavior
(because the name itself implied that this is what the property controls).
Anyways, I think it makes sense then to introduce
`OAuth2Properties.TOKEN_REFRESH_ENABLED` to control the token refresh behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
