nastra commented on code in PR #6837:
URL: https://github.com/apache/iceberg/pull/6837#discussion_r1129056663
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -136,7 +144,11 @@ private AuthSession authSession() {
OAuthTokenResponse authResponse =
OAuth2Util.fetchToken(httpClient(), session.headers(), credential(),
SCOPE);
return AuthSession.fromTokenResponse(
- httpClient(), TOKEN_REFRESH_EXECUTOR, authResponse, startTimeMillis,
session);
+ httpClient(),
+ keepTokenRefreshed() ? TOKEN_REFRESH_EXECUTOR : null,
Review Comment:
Right now `TOKEN_REFRESH_EXECUTOR` is a static final here. I'll open a
separate PR so that it doesn't get initialized when token refresh is disabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
