rdblue commented on code in PR #6485: URL: https://github.com/apache/iceberg/pull/6485#discussion_r1103901581
########## core/src/main/java/org/apache/iceberg/encryption/envelope/KmsClient.java: ########## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.encryption.envelope; + +import java.io.Closeable; +import java.io.Serializable; +import java.nio.ByteBuffer; +import java.util.Map; + +/** A minimum client interface to connect to a key management service (KMS). */ +interface KmsClient extends Serializable, Closeable { + + /** + * Wrap a secret key, using a wrapping/master key which is stored in KMS and referenced by an ID. + * Wrapping means encryption of the secret key with the master key, and adding optional + * KMS-specific metadata that allows the KMS to decrypt the secret key in an unwrapping call. + * + * @param key a secret key being wrapped + * @param wrappingKeyId a key ID that represents a wrapping key stored in KMS + * @return wrapped key material + */ + ByteBuffer wrapKey(ByteBuffer key, String wrappingKeyId); + + /** + * Some KMS systems support generation of secret keys inside the KMS server. + * + * @return true if KMS server supports key generation and KeyManagementClient implementation is + * interested to leverage this capability. Otherwise, return false - Iceberg will then + * generate secret keys locally (using the SecureRandom mechanism) and call {@link + * #wrapKey(ByteBuffer, String)} to wrap them in KMS. + */ + default boolean supportsKeyGeneration() { + return false; + } + + /** + * Generate a new secret key in the KMS server, and wrap it using a wrapping/master key which is + * stored in KMS and referenced by an ID. This method will be called only if supportsKeyGeneration + * returns true. + * + * @param wrappingKeyId a key ID that represents a wrapping key stored in KMS + * @return key in two forms: raw, and wrapped with the given wrappingKeyId + */ + default KeyGenerationResult generateKey(String wrappingKeyId) { Review Comment: Why are these methods defaulted? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
