rdblue commented on code in PR #6566:
URL: https://github.com/apache/iceberg/pull/6566#discussion_r1071462286
##########
python/pyiceberg/expressions/visitors.py:
##########
@@ -881,3 +881,82 @@ def rewrite_to_dnf(expr: BooleanExpression) ->
Tuple[BooleanExpression, ...]:
# (A AND NOT(B) AND C) OR (NOT(D) AND E AND F) OR (G)
expr_without_not = rewrite_not(expr)
return visit(expr_without_not, _RewriteToDNF())
+
+
+class _to_dask_format(BoundBooleanExpressionVisitor[List[Tuple[str, str,
Any]]]):
+ def visit_in(self, term: BoundTerm[L], literals: Set[L]) ->
List[Tuple[str, str, Any]]:
+ return [(term.ref().field.name, "in", literals)]
+
+ def visit_not_in(self, term: BoundTerm[L], literals: Set[L]) ->
List[Tuple[str, str, Any]]:
+ return [(term.ref().field.name, "not in", literals)]
+
+ def visit_is_nan(self, term: BoundTerm[L]) -> List[Tuple[str, str, Any]]:
+ return [(term.ref().field.name, "==", float("nan"))]
+
+ def visit_not_nan(self, term: BoundTerm[L]) -> List[Tuple[str, str, Any]]:
+ return [(term.ref().field.name, "!=", float("nan"))]
+
+ def visit_is_null(self, term: BoundTerm[L]) -> List[Tuple[str, str, Any]]:
+ return [(term.ref().field.name, "==", None)]
+
+ def visit_not_null(self, term: BoundTerm[L]) -> List[Tuple[str, str, Any]]:
+ return [(term.ref().field.name, "!=", None)]
+
+ def visit_equal(self, term: BoundTerm[L], literal: Literal[L]) ->
List[Tuple[str, str, Any]]:
+ return [(term.ref().field.name, "==", literal.value)]
+
+ def visit_not_equal(self, term: BoundTerm[L], literal: Literal[L]) ->
List[Tuple[str, str, Any]]:
+ return [(term.ref().field.name, "!=", literal.value)]
+
+ def visit_greater_than_or_equal(self, term: BoundTerm[L], literal:
Literal[L]) -> List[Tuple[str, str, Any]]:
+ return [(term.ref().field.name, ">=", literal.value)]
+
+ def visit_greater_than(self, term: BoundTerm[L], literal: Literal[L]) ->
List[Tuple[str, str, Any]]:
+ return [(term.ref().field.name, ">", literal.value)]
+
+ def visit_less_than(self, term: BoundTerm[L], literal: Literal[L]) ->
List[Tuple[str, str, Any]]:
+ return [(term.ref().field.name, "<", literal.value)]
+
+ def visit_less_than_or_equal(self, term: BoundTerm[L], literal:
Literal[L]) -> List[Tuple[str, str, Any]]:
+ return [(term.ref().field.name, "<=", literal.value)]
+
+ def visit_true(self) -> List[Tuple[str, str, Any]]:
+ return [] # Not supported
Review Comment:
I think this is okay. Zero filters basically do the same thing as `true`.
The problem is converting `false` into the same thing. I think for that, we
should throw an exception because it cannot be safely handled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
