rdblue commented on code in PR #6485: URL: https://github.com/apache/iceberg/pull/6485#discussion_r1099333500
########## api/src/main/java/org/apache/iceberg/encryption/KmsClient.java: ########## @@ -22,7 +22,11 @@ import java.nio.ByteBuffer; import java.util.Map; -/** A minimum client interface to connect to a key management service (KMS). */ +/** + * @deprecated the API will be removed in v2.0.0 (replaced with KeyManagementClient interface). A + * minimum client interface to connect to a key management service (KMS). Review Comment: This mixes the description and the deprecation note. Can you fix that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
