[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6772: Core: enforce writing POSIX compatible paths for data location

[via GitHub]

jackye1995 commented on code in PR #6772:
URL: https://github.com/apache/iceberg/pull/6772#discussion_r1103698178


##########
core/src/main/java/org/apache/iceberg/util/LocationUtil.java:
##########
@@ -33,4 +34,8 @@ public static String stripTrailingSlash(String path) {
     }
     return result;
   }
+
+  public static String posixNormalize(String path) {
+    return Paths.get(path).normalize().toString();

Review Comment:
   Looks like using URI is still not the right way, because URI would fail with 
characters like space, which are supposed to be escaped with URL encoding like 
`%20`
   
   I think what should be done is that, for path with scheme and optional 
authority, everything after that should use 
`Paths.get(path).normalize().toString()`.



##########
core/src/main/java/org/apache/iceberg/util/LocationUtil.java:
##########
@@ -33,4 +34,8 @@ public static String stripTrailingSlash(String path) {
     }
     return result;
   }
+
+  public static String posixNormalize(String path) {
+    return Paths.get(path).normalize().toString();

Review Comment:
   Looks like using URI is still not the right way, because URI would fail with 
characters like space, which are supposed to be escaped with URL encoding like 
`%20`
   
   I think what should be done is that, for path with scheme and authority, 
everything after that should use `Paths.get(path).normalize().toString()`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org