jackye1995 commented on code in PR #6772:
URL: https://github.com/apache/iceberg/pull/6772#discussion_r1100330049


##########
core/src/test/java/org/apache/iceberg/TestLocationProvider.java:
##########
@@ -297,4 +297,17 @@ public void testObjectStorageWithinTableLocation() {
     Assert.assertEquals(
         "Fourth part should be the file name passed in", "test.parquet", 
parts.get(3));
   }
+
+  @Test

Review Comment:
   Put up for discussion first while writing tests in case we want to talk 
about it during community sync



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to