rdblue commented on code in PR #6755:
URL: https://github.com/apache/iceberg/pull/6755#discussion_r1097913008
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java:
##########
@@ -192,6 +194,14 @@ public Map<String, String> extraSnapshotMetadata() {
}
});
+ final Iterator<Tuple2<String, String>> it =
sessionConf.getAll().iterator();
+ while (it.hasNext()) {
Review Comment:
Rather than using Scala objects, which are awkward in Java, we like to use
Scala's conversions to get Java objects:
```java
import scala.collection.JavaConverters;
Map<String, String> javaMap =
JavaConverters.mapAsJavaMapConverter(sessionConf.getAll()).asJava();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
