rdblue commented on code in PR #6755:
URL: https://github.com/apache/iceberg/pull/6755#discussion_r1097909160
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java:
##########
@@ -192,6 +194,14 @@ public Map<String, String> extraSnapshotMetadata() {
}
});
+ final Iterator<Tuple2<String, String>> it =
sessionConf.getAll().iterator();
+ while (it.hasNext()) {
+ final Tuple2<String, String> entry = it.next();
+ if (entry._1.startsWith("spark." +
SnapshotSummary.EXTRA_METADATA_PREFIX)) {
+ extraSnapshotMetadata.put(
+ entry._1.substring(6 +
SnapshotSummary.EXTRA_METADATA_PREFIX.length()), entry._2);
Review Comment:
Can you make private static constants rather than embedding `6` and `spark.`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
