aokolnychyi commented on code in PR #6655:
URL: https://github.com/apache/iceberg/pull/6655#discussion_r1096374242
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java:
##########
@@ -67,14 +62,13 @@ public boolean caseSensitive() {
}
public boolean localityEnabled() {
- if (table.io() instanceof HadoopFileIO) {
- HadoopInputFile file = (HadoopInputFile)
table.io().newInputFile(table.location());
- String scheme = file.getFileSystem().getScheme();
- boolean defaultValue = LOCALITY_WHITELIST_FS.contains(scheme);
+ if (Util.usesHadoopFileIO(table.io(), table.location())) {
Review Comment:
@singhpk234, I think `Util.mayHaveBlockLocations` internally calls
`usesHadoopFileIO` so I am not sure I got your point
[here](https://github.com/apache/iceberg/pull/6655#discussion_r1095306379). If
so, I'd simplify this and make `usesHadoopFileIO` private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
