aokolnychyi commented on code in PR #6655:
URL: https://github.com/apache/iceberg/pull/6655#discussion_r1093713311
##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -164,7 +164,7 @@ private FileIO io(String location) {
return io;
}
- private static String implFromLocation(String location) {
+ public static String implFromLocation(String location) {
Review Comment:
I agree. What about adding a new method called `ioClass` like this?
```
public Class<? extends FileIO> ioClass(String location) {
return io(location).getClass();
}
```
We could also rename `implFromLocation` to be `ioClassName` and open it but
it won't be possible to check if a particular file IO is a subtype of
`HadoopFileIO`. I believe the existing code can handle that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
