aokolnychyi commented on code in PR #6655:
URL: https://github.com/apache/iceberg/pull/6655#discussion_r1093714980
##########
core/src/main/java/org/apache/iceberg/hadoop/Util.java:
##########
@@ -84,10 +84,16 @@ public static String[] blockLocations(FileIO io,
ScanTaskGroup<?> taskGroup) {
return locations.toArray(HadoopInputFile.NO_LOCATION_PREFERENCE);
}
+ public static boolean isHDFSLocation(FileIO io, String location) {
Review Comment:
I like `usesHadoopFileIO`. I'd also have explicit if else statements as the
current formatting is hard to read.
```
private static boolean usesHadoopFileIO(FileIO io, String location) {
if (io instanceof HadoopFileIO) {
return true;
} else if (io instanceof ResolvingFileIO) {
ResolvingFileIO resolvingFileIO = (ResolvingFileIO) io;
return ...
} else {
return false;
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
