dimas-b commented on code in PR #6712:
URL: https://github.com/apache/iceberg/pull/6712#discussion_r1093528350
##########
nessie/src/test/java/org/apache/iceberg/nessie/TestNamespace.java:
##########
@@ -73,6 +77,53 @@ public void testListNamespaces() {
Assertions.assertThat(namespaces).isNotNull().hasSize(2);
}
+ @Test
+ @NessieApiVersions(versions = NessieApiVersion.V1)
+ public void testNamespacesWithV1Api() {
+ createNamespacesAndTables();
+
+ testListTables();
+
+ List<Namespace> namespaces;
+ namespaces = catalog.listNamespaces(Namespace.of("foo"));
+ // NessieApiV1 should include both implicit and explicit namespaces
+ Assertions.assertThat(namespaces)
+ .isNotNull()
+ .hasSize(2)
+ .isEqualTo(Arrays.asList(Namespace.of("foo"), Namespace.of("foo",
"bar")));
Review Comment:
Is the list order guaranteed? Why not `.containsExactlyInAnyOrder`?
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieUtil.java:
##########
@@ -37,6 +37,8 @@ public final class NessieUtil {
public static final String NESSIE_CONFIG_PREFIX = "nessie.";
static final String APPLICATION_TYPE = "application-type";
+ public static final String CLIENT_API_VERSION = "client-api-version";
Review Comment:
Not sure about that. Whether API v1 or v2 is used depends on what the client
(e.g. `NessieCatalog`) expects and how its code is written. I think it is
proper to have this config option defined on the catalog side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
