dimas-b commented on code in PR #6712:
URL: https://github.com/apache/iceberg/pull/6712#discussion_r1093344545
##########
nessie/src/test/java/org/apache/iceberg/nessie/TestNamespace.java:
##########
@@ -63,14 +65,56 @@ public void testListNamespaces() {
tables = catalog.listTables(null);
Assertions.assertThat(tables).isNotNull().hasSize(6);
- List<Namespace> namespaces = catalog.listNamespaces();
- Assertions.assertThat(namespaces).isNotNull().hasSize(5);
- namespaces = catalog.listNamespaces(Namespace.of("a"));
- Assertions.assertThat(namespaces).isNotNull().hasSize(3);
- namespaces = catalog.listNamespaces(Namespace.of("a", "b"));
- Assertions.assertThat(namespaces).isNotNull().hasSize(2);
- namespaces = catalog.listNamespaces(Namespace.of("b"));
- Assertions.assertThat(namespaces).isNotNull().hasSize(2);
+ List<Namespace> namespaces;
+ if (api instanceof NessieApiV2) {
Review Comment:
Whenever test logic different, I think it would be nice to have one method
for v1 and another for v2, each annotated with `@NessieApiVersions(...)` for
its specific target version. Common code could be refactored into utility
methods. WDYT?
##########
nessie/src/test/java/org/apache/iceberg/nessie/TestNamespace.java:
##########
@@ -63,14 +65,56 @@ public void testListNamespaces() {
tables = catalog.listTables(null);
Assertions.assertThat(tables).isNotNull().hasSize(6);
- List<Namespace> namespaces = catalog.listNamespaces();
- Assertions.assertThat(namespaces).isNotNull().hasSize(5);
- namespaces = catalog.listNamespaces(Namespace.of("a"));
- Assertions.assertThat(namespaces).isNotNull().hasSize(3);
- namespaces = catalog.listNamespaces(Namespace.of("a", "b"));
- Assertions.assertThat(namespaces).isNotNull().hasSize(2);
- namespaces = catalog.listNamespaces(Namespace.of("b"));
- Assertions.assertThat(namespaces).isNotNull().hasSize(2);
+ List<Namespace> namespaces;
+ if (api instanceof NessieApiV2) {
Review Comment:
Whenever test logic differs, I think it would be nice to have one method for
v1 and another for v2, each annotated with `@NessieApiVersions(...)` for its
specific target version. Common code could be refactored into utility methods.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
