dimas-b commented on code in PR #6712:
URL: https://github.com/apache/iceberg/pull/6712#discussion_r1092350427
##########
nessie/src/test/java/org/apache/iceberg/nessie/TestNamespace.java:
##########
@@ -63,14 +65,56 @@ public void testListNamespaces() {
tables = catalog.listTables(null);
Assertions.assertThat(tables).isNotNull().hasSize(6);
- List<Namespace> namespaces = catalog.listNamespaces();
- Assertions.assertThat(namespaces).isNotNull().hasSize(5);
- namespaces = catalog.listNamespaces(Namespace.of("a"));
- Assertions.assertThat(namespaces).isNotNull().hasSize(3);
- namespaces = catalog.listNamespaces(Namespace.of("a", "b"));
- Assertions.assertThat(namespaces).isNotNull().hasSize(2);
- namespaces = catalog.listNamespaces(Namespace.of("b"));
- Assertions.assertThat(namespaces).isNotNull().hasSize(2);
+ List<Namespace> namespaces;
+ if (api instanceof NessieApiV2) {
Review Comment:
Would it be possible to use `@NessieApiVersions` test annotations to avoid
this kind of `if` is test code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
