stevenzwu commented on code in PR #6660:
URL: https://github.com/apache/iceberg/pull/6660#discussion_r1089604601
##########
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSink.java:
##########
@@ -85,28 +86,29 @@ public class TestFlinkIcebergSink {
private final int parallelism;
private final boolean partitioned;
- @Parameterized.Parameters(name = "format={0}, parallelism = {1}, partitioned
= {2}")
+ @Parameterized.Parameters(name = "format={0}, parallelism = {1}, partitioned
= {2}, branch = {3}")
Review Comment:
here are some stats from one local run (a powerful M1 macbook)
* TestFlinkIcebergSink: 36s
* TestFlinkIcebergSinkV2: 77s
* TestIcebergFilesCommitter: 19s
If we double it, the total build time for those 3 classes will increase from
132s (2m) to 264s (4m). If we add another dimension/multiplication after this,
it will increase from 4+ mins to 8-9 mins.
The expo growth was my concern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
