amogh-jahagirdar commented on code in PR #6660:
URL: https://github.com/apache/iceberg/pull/6660#discussion_r1089580257
##########
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSink.java:
##########
@@ -85,28 +86,29 @@ public class TestFlinkIcebergSink {
private final int parallelism;
private final boolean partitioned;
- @Parameterized.Parameters(name = "format={0}, parallelism = {1}, partitioned
= {2}")
+ @Parameterized.Parameters(name = "format={0}, parallelism = {1}, partitioned
= {2}, branch = {3}")
Review Comment:
@stevenzwu @jackye1995 I added this separate class and moved common logic
between the sink/sinkv2 tests to TestFlinkIcebergSinkBase. After implementing,
now I'm not sure if it's worth refactoring the code. Even though with the
previous approach there's 2x the combinations which was unnecessary, it was a
less intrusive to the test code and easier to read. Also running locally with
2x the combinations was still quite quick. Let me know your thoughts on what
you prefer!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
