stevenzwu commented on code in PR #6660:
URL: https://github.com/apache/iceberg/pull/6660#discussion_r1088409938
##########
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/SimpleDataUtil.java:
##########
@@ -267,13 +274,25 @@ public static void assertTableRecords(
}
public static void assertTableRecords(Table table, List<Record> expected)
throws IOException {
+ assertTableRecords(table, expected, SnapshotRef.MAIN_BRANCH);
+ }
+
+ public static void assertTableRecords(Table table, List<Record> expected,
String branch)
+ throws IOException {
table.refresh();
+ Snapshot snapshot = latestSnapshot(table, branch);
+
+ if (snapshot == null) {
+ Assert.assertEquals(ImmutableList.of(), expected);
Review Comment:
the assertion order is incorrect. should be `(expected, actual)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
