RussellSpitzer commented on code in PR #6554:
URL: https://github.com/apache/iceberg/pull/6554#discussion_r1087115907
##########
data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilterTypes.java:
##########
@@ -212,74 +218,82 @@ public void createParquetInputFile(List<Record> records)
throws IOException {
appender.addAll(records);
}
- InputFile inFile = Files.localInput(PARQUET_FILE);
+ InputFile inFile = Files.localInput(parquetFile);
try (ParquetFileReader reader =
ParquetFileReader.open(parquetInputFile(inFile))) {
Assert.assertEquals("Should create only one row group", 1,
reader.getRowGroups().size());
rowGroupMetadata = reader.getRowGroups().get(0);
parquetSchema = reader.getFileMetaData().getSchema();
}
- PARQUET_FILE.deleteOnExit();
+ parquetFile.deleteOnExit();
}
private final FileFormat format;
private final String column;
private final Object readValue;
private final Object skipValue;
+ // float or double type contain nans can't pushDown to skip
+ private final boolean unableSkip;
Review Comment:
Rather than modify the whole test, I think we would just make special cases
for the float and double with Nans, I actually think this is covered fine in
the other MetricRowGroupFilter test so we can probably just leave this file
alone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
