RussellSpitzer commented on code in PR #6554:
URL: https://github.com/apache/iceberg/pull/6554#discussion_r1084324653
##########
data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilterTypes.java:
##########
@@ -144,8 +144,8 @@ public void createInputFile() throws IOException {
record.setField("_boolean", false);
record.setField("_int", i);
record.setField("_long", 5_000_000_000L + i);
- record.setField("_float", ((float) (100 - i)) / 100F + 1.0F); // 2.0f,
1.99f, 1.98f, ...
- record.setField("_double", ((double) i) / 100.0D + 2.0D); // 2.0d,
2.01d, 2.02d, ...
+ record.setField("_float", (i % 10 == 0) ? Float.NaN : ((float) (100 -
i)) / 100F + 1.0F); // 2.0f, 1.99f, 1.98f, ... OR NAN
+ record.setField("_double", (i % 10 == 0) ? Double.NaN : ((double) i) /
100.0D + 2.0D); // 2.0d, 2.01d, 2.02d, ... OR NAN
Review Comment:
We probably shouldn't do that here. we can do negative tests as long as
there aren't NANs correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
