rdblue commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1055945851


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/StructInternalRow.java:
##########
@@ -356,4 +357,23 @@ private <T> GenericArrayData fillArray(
 
     return new GenericArrayData(array);
   }
+
+  @Override
+  public boolean equals(Object other) {

Review Comment:
   What is the contract for equals for `InternalRow`? This probably works, but 
does it indicate a bug in Spark where Spark assumes that `InternalRow` 
implementations consider one another equal?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to