rdblue commented on code in PR #6371: URL: https://github.com/apache/iceberg/pull/6371#discussion_r1055945015
########## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkScan.java: ########## @@ -147,9 +152,9 @@ protected Statistics estimateStatistics(Snapshot snapshot) { @Override public String description() { - String filters = - filterExpressions.stream().map(Spark3Util::describe).collect(Collectors.joining(", ")); - return String.format("%s [filters=%s]", table, filters); + return String.format( + "%s [filters=%s, groupedBy=%s]", + table(), Spark3Util.describe(filterExpressions), groupingKeyType()); Review Comment: Do we want a simpler grouping expression? This is going to show `struct<...>` where we may just want the column names from that struct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org