rdblue commented on code in PR #6371: URL: https://github.com/apache/iceberg/pull/6371#discussion_r1055944636
########## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ########## @@ -473,6 +490,10 @@ private static String parentName(String[] fieldNames) { return null; } + public static String describe(List<org.apache.iceberg.expressions.Expression> exprs) { + return exprs.stream().map(Spark3Util::describe).collect(Collectors.joining(", ")); Review Comment: Actually, this is used by `toString`, so it looks like the right behavior is to not sanitize because this is put into Spark plans where the full filter should be shown. We may want to introduce a sanitized describe later though, for logging purposes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org