[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #6267: Core: Update StatisticsFile interface in TableMetadata spec

[GitBox]

ajantha-bhat commented on code in PR #6267:
URL: https://github.com/apache/iceberg/pull/6267#discussion_r1044050182


##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1183,14 +1222,16 @@ public Builder setStatistics(long snapshotId, 
StatisticsFile statisticsFile) {
           "snapshotId does not match: %s vs %s",
           snapshotId,
           statisticsFile.snapshotId());
-      statisticsFiles.put(statisticsFile.snapshotId(), 
ImmutableList.of(statisticsFile));

Review Comment:
   @rdblue, @findepi:  
   It is just as per the previous existing interface in the builder. 
   we had `Map<Long, List<StatisticsFile>> statisticsFiles` in builder. 
   If we wanted one stats file per interface then no need to have list for map 
value?
   
   Also is it possible that there will be one partition level stats 
(avro/parquet file) and there is one table level NDV file per snapshot. In this 
case, no need to merge them but can be used based on the need. So, still ok to 
have multiple stats per snapshot id?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org