rdblue commented on code in PR #6267:
URL: https://github.com/apache/iceberg/pull/6267#discussion_r1043909381
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1183,14 +1222,16 @@ public Builder setStatistics(long snapshotId,
StatisticsFile statisticsFile) {
"snapshotId does not match: %s vs %s",
snapshotId,
statisticsFile.snapshotId());
- statisticsFiles.put(statisticsFile.snapshotId(),
ImmutableList.of(statisticsFile));
Review Comment:
This is not correct. There should be only one stats file for a snapshot that
contains all information. Allowing multiple stats files for a snapshot is going
to lead to lazy implementations that don't merge the files and slower job
planning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
