rdblue commented on code in PR #6267:
URL: https://github.com/apache/iceberg/pull/6267#discussion_r1043908619


##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -793,6 +822,18 @@ private static Map<String, SnapshotRef> validateRefs(
     return inputRefs;
   }
 
+  private long computeStatisticsCheckpointSnapshotID() {

Review Comment:
   This doesn't make sense to me and I suspect it should be removed. There is 
no guaranteed order to `snapshots` and the snapshots in that list can be from 
different branches. The first snapshot with a valid stats file has no meaning.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to