RussellSpitzer commented on code in PR #5376:
URL: https://github.com/apache/iceberg/pull/5376#discussion_r1025808348
##########
core/src/main/java/org/apache/iceberg/MetricsUtil.java:
##########
@@ -56,4 +72,270 @@ public static MetricsModes.MetricsMode metricsMode(
String columnName = inputSchema.findColumnName(fieldId);
return metricsConfig.columnMode(columnName);
}
+
+ public static final List<ReadableMetricCol> READABLE_COL_METRICS =
+ ImmutableList.of(
+ new ReadableMetricCol("column_size", f -> Types.LongType.get(),
"Total size on disk"),
+ new ReadableMetricCol(
+ "value_count", f -> Types.LongType.get(), "Total count,
including null and NaN"),
+ new ReadableMetricCol("null_value_count", f -> Types.LongType.get(),
"Null value count"),
+ new ReadableMetricCol("nan_value_count", f -> Types.LongType.get(),
"NaN value count"),
+ new ReadableMetricCol("lower_bound", Types.NestedField::type, "Lower
bound"),
+ new ReadableMetricCol("upper_bound", Types.NestedField::type, "Upper
bound"));
+
+ public static final String READABLE_METRICS = "readable_metrics";
+
+ public static class ReadableMetricCol {
+ private final String name;
+ private final Function<Types.NestedField, Type> typeFunction;
+ private final String doc;
+
+ ReadableMetricCol(String name, Function<Types.NestedField, Type>
typeFunction, String doc) {
+ this.name = name;
+ this.typeFunction = typeFunction;
+ this.doc = doc;
+ }
+
+ String name() {
+ return name;
+ }
+
+ Type type(Types.NestedField field) {
+ return typeFunction.apply(field);
+ }
+
+ String doc() {
+ return doc;
+ }
+ }
+
+ /**
+ * Represents a struct of metrics for a primitive column
+ *
+ * @param <T> primitive column type
+ */
+ public static class ReadableColMetricsStruct<T> implements StructLike {
+
+ private final String columnName;
+ private final Long columnSize;
+ private final Long valueCount;
+ private final Long nullValueCount;
+ private final Long nanValueCount;
+ private final T lowerBound;
+ private final T upperBound;
+ private final Map<Integer, Integer> projectionMap;
+
+ public ReadableColMetricsStruct(
+ String columnName,
+ Long columnSize,
+ Long valueCount,
+ Long nullValueCount,
+ Long nanValueCount,
+ T lowerBound,
+ T upperBound,
+ Types.NestedField projection) {
+ this.columnName = columnName;
+ this.columnSize = columnSize;
+ this.valueCount = valueCount;
+ this.nullValueCount = nullValueCount;
+ this.nanValueCount = nanValueCount;
+ this.lowerBound = lowerBound;
+ this.upperBound = upperBound;
+ this.projectionMap = readableMetricsProjection(projection);
+ }
+
+ @Override
+ public int size() {
+ return projectionMap.size();
+ }
+
+ @Override
+ public <T> T get(int pos, Class<T> javaClass) {
+ Object value = get(pos);
+ return value == null ? null : javaClass.cast(value);
+ }
+
+ @Override
+ public <T> void set(int pos, T value) {
+ throw new UnsupportedOperationException("ReadableMetricsStruct is read
only");
+ }
+
+ private Object get(int pos) {
+ int projectedPos = projectionMap.get(pos);
+ switch (projectedPos) {
+ case 0:
+ return columnSize;
+ case 1:
+ return valueCount;
+ case 2:
+ return nullValueCount;
+ case 3:
+ return nanValueCount;
+ case 4:
+ return lowerBound;
+ case 5:
+ return upperBound;
+ default:
+ throw new IllegalArgumentException(
+ String.format("Invalid projected pos %d", projectedPos));
+ }
+ }
+
+ /** @return map of projected position to actual position of this struct's
fields */
Review Comment:
I didn't think we allowed 1 line java docs like this? There should be an
alert that we don't do @return ...., for single line java docs it should just
be "return ...." so that the summary is filled in the java doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
