szehon-ho commented on code in PR #5376:
URL: https://github.com/apache/iceberg/pull/5376#discussion_r1024931871


##########
api/src/main/java/org/apache/iceberg/Schema.java:
##########
@@ -233,6 +233,16 @@ public Map<String, Integer> getAliases() {
     return aliasToId;
   }
 
+  /**
+   * Returns a map for this schema between field id and qualified field names. 
Initializes the map,
+   * if it has not been initialized by calls to {@link #findColumnName(int)}.
+   *
+   * @return a map of field id to qualified field names
+   */
+  public Map<Integer, String> idToName() {

Review Comment:
   Yea I had a memory of discussing this with @aokolnychyi but cant remember 
now for sure :)
   
   From looking now, I guess I need the list of ids as well, and so thought 
might as well return the map (as laziness wise its just as expensive to compute 
list of ids as the whole map).  I updated the comment, but let me know if you 
prefer something else.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to