szehon-ho commented on code in PR #5376: URL: https://github.com/apache/iceberg/pull/5376#discussion_r1026573190
########## core/src/main/java/org/apache/iceberg/BaseFilesTable.java: ########## @@ -186,4 +224,43 @@ ManifestFile manifest() { return manifest; } } + + static class ContentFileStructWithMetrics implements StructLike { + private final int structSize; + private final StructLike fileAsStruct; + private final MetricsUtil.ReadableMetricsStruct readableMetrics; + + ContentFileStructWithMetrics( + int structSize, Review Comment: I tried to change the code and didnt work. This is actually the expectedSize (to use the terminology in other places, aka the user-requested size). The fileAsStruct.size() is actually always all the possible DataFile values, if they are not projected they are just null.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org